cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14225) Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml
Date Sun, 02 Sep 2018 02:39:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599902#comment-16599902
] 

ASF GitHub Bot commented on CB-14225:
-------------------------------------

janpio closed pull request #286: CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml
URL: https://github.com/apache/cordova-windows/pull/286
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/template/Properties/Default.rd.xml b/template/Properties/Default.rd.xml
index 3b46199c..4ab5e934 100644
--- a/template/Properties/Default.rd.xml
+++ b/template/Properties/Default.rd.xml
@@ -12,7 +12,7 @@
     <TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" Activate="Required
Public" />
 
     Using the Namespace directive to apply reflection policy to all the types in a particular
namespace
-    <Namespace Name="DataClasses.ViewModels" Seralize="All" />
+    <Namespace Name="DataClasses.ViewModels" Serialize="All" />
 
     The MIT License (MIT)
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml
> ------------------------------------------------------------------------------
>
>                 Key: CB-14225
>                 URL: https://issues.apache.org/jira/browse/CB-14225
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Minor
>
> If I would generate a new UWP C# project using Visual Studio 2017 and copy the generated
{{Default.rd.xml}} file into {{template\Properties}} then I would see the following diff:
> {code:xml}
> index 7c40ffeb..af00722c 100644
> --- a/template/Properties/Default.rd.xml
> +++ b/template/Properties/Default.rd.xml
> @@ -12,7 +12,7 @@
>      <TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" Activate="Required
Public" />
>      Using the Namespace directive to apply reflection policy to all the types in a particular
namespace
> -    <Namespace Name="DataClasses.ViewModels" Seralize="All" />
> +    <Namespace Name="DataClasses.ViewModels" Serialize="All" />
>  -->
>  <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
> {code}
> I propose to commit this change to the master branch.
> Related:
> * CB-12499 - introduced {{template/Properties/Default.rd.xml}}
> * CB-14224 - proposal to add license text to the header
> * [Microsoft/Windows-universal-samples#950|https://github.com/Microsoft/Windows-universal-samples/pull/950]
- similar proposal for [Microsoft / Windows-universal-samples|https://github.com/Microsoft/Windows-universal-samples]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message