From issues-return-97040-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org Tue Sep 4 18:25:03 2018 Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F9251C207 for ; Tue, 4 Sep 2018 18:25:03 +0000 (UTC) Received: (qmail 24614 invoked by uid 500); 4 Sep 2018 18:25:03 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 24596 invoked by uid 500); 4 Sep 2018 18:25:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 24585 invoked by uid 99); 4 Sep 2018 18:25:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Sep 2018 18:25:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BADF4C5696 for ; Tue, 4 Sep 2018 18:25:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id NMX9CEeA38Al for ; Tue, 4 Sep 2018 18:25:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1E1445F572 for ; Tue, 4 Sep 2018 18:25:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 471A6E25B2 for ; Tue, 4 Sep 2018 18:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6146726B5B for ; Tue, 4 Sep 2018 18:25:00 +0000 (UTC) Date: Tue, 4 Sep 2018 18:25:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603421#comment-16603421 ] ASF GitHub Bot commented on CB-14140: ------------------------------------- raphinesse commented on issue #613: CB-14140 Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418469969 I squashed some of the commits and will merge (with merge commit) as soon as the CI tests are done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Use fs-extra (and which) instead of shelljs > ------------------------------------------- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, cordova-windows > Reporter: Chris Brody > Assignee: Darryl Pogue > Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, than shelljs. > This improvement has already landed in the master branch of cordova-common for the next major release, and work has already been started in some other packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org