[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605746#comment-16605746 ] 

ASF GitHub Bot commented on CB-14166:
-------------------------------------

janpio commented on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows
URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-419086421
 
 
   So we finally figured out what was going on, please read in the JIRA issue:
   https://issues.apache.org/jira/browse/CB-14166?focusedCommentId=16605718&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16605718
   
   Short version: 
   Nodist, which the issue reported and creator of this PR are using to manage their local node/npm installations, installs a `npm.exe` next to `npm.cmd` which is then used to execute the command because `which npm` returns its path. It behaves differently, which causes the command to fail for them.
   
   Thanks @AlmirKadric for creating this PR anyway, it helped to understand the problem better. 
   Another PR seems to be incoming that will solve this problem in another way.
   
   PS: `nvm-windows` doesn't have this problem: https://github.com/coreybutler/nvm-windows

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cordova on windows fails when adding plugin
> -------------------------------------------
>
>                 Key: CB-14166
>                 URL: https://issues.apache.org/jira/browse/CB-14166
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: takuya
>            Assignee: Jesse MacFadyen
>            Priority: Blocker
>         Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org