From issues-return-97059-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org Wed Sep 5 13:15:03 2018 Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B69F81DF96 for ; Wed, 5 Sep 2018 13:15:03 +0000 (UTC) Received: (qmail 48175 invoked by uid 500); 5 Sep 2018 13:15:03 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 48150 invoked by uid 500); 5 Sep 2018 13:15:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 48139 invoked by uid 99); 5 Sep 2018 13:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 13:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9B72FC64AF for ; Wed, 5 Sep 2018 13:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AmICbTQgPTa0 for ; Wed, 5 Sep 2018 13:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 679BF5F48D for ; Wed, 5 Sep 2018 13:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8F76FE0F4C for ; Wed, 5 Sep 2018 13:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B1342183F for ; Wed, 5 Sep 2018 13:15:00 +0000 (UTC) Date: Wed, 5 Sep 2018 13:15:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604386#comment-16604386 ] ASF GitHub Bot commented on CB-14211: ------------------------------------- raphinesse edited a comment on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418725174 @janpio @oliversalzburg This all started with #622 which challenges the correctness of the escaping done in lib for some shells. Thus, we should start with unit tests for `superspawn` in `cordova-common` that test (or show the absence of) escaping. For example by calling `superspawn` to write some special characters to a file and check the result. After we have a better understanding of the problems at hand and we still feel it's necessary, we could select a few tests to form a smoke test suite for lib on PowerShell that we run on CI in addition to our regular tests. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > --------------------------------------------------------------------- > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib > Reporter: Oliver Salzburg > Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org