cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
Date Tue, 16 Oct 2018 05:38:00 GMT

    [ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651149#comment-16651149
] 

ASF GitHub Bot commented on CB-7179:
------------------------------------

purplecabbage commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support
for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225402732
 
 

 ##########
 File path: tests/plugin.xml
 ##########
 @@ -29,5 +29,12 @@
     <js-module src="tests.js" name="tests">
     </js-module>
 
+    <platform name="ios">
+      <!-- The WKWebView implementation for inappbrowser requires the presence of this
plugin  -->
+      <dependency id="cordova-plugin-wkwebview-engine" />
+      <dependency id="cordova-plugin-wkwebview-engine-allowfileaccess" url="https://github.com/knight9999/cordova-plugin-wkwebview-engine-allowfileaccess.git"
/>
 
 Review comment:
   The plugin itself is only 2 lines. There are a couple things we could do.
   
   1. Ask @knight9999  to publish the allowfileaccess plugin to npm, and have our test depend
on that published version.
   2. make the wk-allowfileaccess a cordova supported plugin, and also do suggestion 1, but
replace Ken with 'we'
   3. revisit the decision to not allow file access directly in the wkwebview plugin, could
we just default to NO, but allow the developer to turn it on? ( This would require a firm
warning about app store rejection possibilities, so it might make things too easy for developers
and lead to rejections. )
   4. Include it in the paramedic repo as a spec plugin, as suggested by Ken [1]
   
   
   
   
   [1] https://github.com/apache/cordova-paramedic/issues/52
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
>                 Key: CB-7179
>                 URL: https://issues.apache.org/jira/browse/CB-7179
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-plugin-inappbrowser
>         Environment: iOS 8
>            Reporter: Shazron Abdullah
>            Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message