cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
Date Fri, 05 Oct 2018 20:42:00 GMT

    [ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640323#comment-16640323
] 

ASF GitHub Bot commented on CB-7179:
------------------------------------

dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-427492841
 
 
   @janpio I think I've figured out why the tests are failing in this PR, even in Xcode 8.3/iOS
10:
   
   This PR requires that `cordova-plugin-wkwebview-engine` be present in the Cordova project
so its classes can be used by the WKWebView implementation in this PR. This means the main
Cordova Webview is using WKWebView instead of UIWebView. And this seems to screw up `cordova-paramedic`
- it can no longer communicate its results back to the local server.
   
   I confirmed this by running `cordova-paramedic` against your [janpio-xcode8.3 branch](https://github.com/apache/cordova-plugin-inappbrowser/tree/janpio-xcode8.3)
first without `cordova-plugin-wkwebview-engine` present (i.e. using UIWebView):
   
   ![screenshot 2018-10-05 at 21 06 20](https://user-images.githubusercontent.com/2345062/46558914-90ab9f80-c8e6-11e8-976b-abf4e5578eee.png)
    
   Then with  `cordova-plugin-wkwebview-engine` present (i.e. using WKWebView):
   
   ![screenshot 2018-10-05 at 21 17 41](https://user-images.githubusercontent.com/2345062/46558937-a4ef9c80-c8e6-11e8-9cd3-33d19b279b79.png)
   
   As you can see, in this second case the tests timed out while trying to connect to the
local server, leading to the same error observed in the Travis CI logs. However, as you can
see from the Simulator screenshot, all the tests passed.
   
   I then ran the `cordova-paramedic` against the branch for this PR:
   
   ![screenshot 2018-10-05 at 21 34 05](https://user-images.githubusercontent.com/2345062/46559031-f13adc80-c8e6-11e8-8486-6d7fef3bbff4.png)
   
   As you can see, a similar result: all tests passed in the Simulator, but tests failed due
to a timeout connecting to the local server.
   
   The upshot it that it seems currently `cordova-paramedic` is not compatible when the main
Cordova Webview is WKWebView and this presents a problem for this PR which requires it to
be so.
   
   I'm guessing since UIWebView is now deprecated in iOS 12, we'll be moving at some point
to make WKWebView the default Cordova Webview (in `cordova-ios@5` ??), so at some point `cordova-paramedic`
is going to need to be fixed to work with WKWebView.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
>                 Key: CB-7179
>                 URL: https://issues.apache.org/jira/browse/CB-7179
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-plugin-inappbrowser
>         Environment: iOS 8
>            Reporter: Shazron Abdullah
>            Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message