cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
Date Mon, 01 Oct 2018 20:04:00 GMT

    [ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634551#comment-16634551
] 

ASF GitHub Bot commented on CB-11714:
-------------------------------------

janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto()
without height/width
URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426043765
 
 
   Thanks @DisruptiveMind.
   
   Tests are now failing because of
   ```
   /Users/travis/build/apache/cordova-plugin-camera/src/windows/CameraProxy.js
     790:67  error  Strings must use singlequote  quotes
   ✖ 1 problem (1 error, 0 warnings)
     1 error, 0 warnings potentially fixable with the `--fix` option.
   ```
   This doesn't make too much sense to me, especially as line 790 contains no quotes at all.
   
   Can you maybe rebase on `master`? I hope this will go away with more recent test configuration.
Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Camera plugin for windows does not properly set content-type when selecting JPG->PNG
> ------------------------------------------------------------------------------------
>
>                 Key: CB-11714
>                 URL: https://issues.apache.org/jira/browse/CB-11714
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>    Affects Versions: Master
>         Environment: Windows 10
>            Reporter: Tyler Pham
>            Priority: Major
>              Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the resizeImage() will
not modify the target content type when converting canvas.toDataURL(...) -- the content-type
will still be image/jpeg but with a .png extension which will cause the browser to not render
to image and issue an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message