cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
Date Wed, 03 Oct 2018 22:43:00 GMT

    [ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637573#comment-16637573
] 

ASF GitHub Bot commented on CB-11714:
-------------------------------------

brodybits closed pull request #242: CB-11714: (windows) added check for encoding in savePhoto()
without height/width
URL: https://github.com/apache/cordova-plugin-camera/pull/242
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/windows/CameraProxy.js b/src/windows/CameraProxy.js
index eb10cd2a..b24f6234 100644
--- a/src/windows/CameraProxy.js
+++ b/src/windows/CameraProxy.js
@@ -800,9 +800,14 @@ function savePhoto(picture, options, successCallback, errorCallback)
{
             if (options.targetHeight > 0 && options.targetWidth > 0) {
                 resizeImage(successCallback, errorCallback, picture, options.targetWidth,
options.targetHeight, options.encodingType);
             } else {
+                // CB-11714: check if target content-type is PNG to just rename as *.jpg
since camera is captured as JPEG
+                if (options.encodingType === Camera.EncodingType.PNG) {
+                    picture.name = picture.name.replace(/\.png$/, '.jpg');
+                }
+
                 picture.copyAsync(getAppData().localFolder, picture.name, OptUnique).done(function
(copiedFile) {
-                    successCallback("ms-appdata:///local/" + copiedFile.name);
-                },errorCallback);
+                    successCallback('ms-appdata:///local/' + copiedFile.name);
+                }, errorCallback);
             }
         } else {
             if (options.targetHeight > 0 && options.targetWidth > 0) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Camera plugin for windows does not properly set content-type when selecting JPG->PNG
> ------------------------------------------------------------------------------------
>
>                 Key: CB-11714
>                 URL: https://issues.apache.org/jira/browse/CB-11714
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>    Affects Versions: Master
>         Environment: Windows 10
>            Reporter: Tyler Pham
>            Priority: Major
>              Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the resizeImage() will
not modify the target content type when converting canvas.toDataURL(...) -- the content-type
will still be image/jpeg but with a .png extension which will cause the browser to not render
to image and issue an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message