cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12941) Update typings to latest DefinitelyTyped revision
Date Tue, 02 Oct 2018 09:50:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635224#comment-16635224
] 

ASF subversion and git services commented on CB-12941:
------------------------------------------------------

Commit a0c267fe36be9a97c974f73b9d2160eca54b9828 in cordova-plugin-inappbrowser's branch refs/heads/master
from [~timbru31]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=a0c267f ]

CB-12941: update typings (#267)

### Platforms affected
n/a - development with TypeScript

### What does this PR do?
Updates the typings to match the latest published version on DefinitelyTyped.  
See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 and https://stackoverflow.com/q/42095516/1902598

### What testing has been done on this change?
Project compiles again ;)

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths",
where CB-xxxx is the JIRA ID & "android" is the platform affected.
- n/a: Added automated test coverage as appropriate for this change.

fixes #300


> Update typings to latest DefinitelyTyped revision
> -------------------------------------------------
>
>                 Key: CB-12941
>                 URL: https://issues.apache.org/jira/browse/CB-12941
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>            Reporter: Tim Brust
>            Priority: Major
>              Labels: inappbrowser, plugins, typescript, typings
>
> Update the typings in the cordova-plugin-inappbrowser to match the current revision published
via DefinitelyTyped.
> This fixes e.g. this issue: https://stackoverflow.com/q/42095516/1902598
> DefinitelyTyped PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message