cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13502) Android - add support for "setRate" method already available on iOS
Date Wed, 03 Oct 2018 17:12:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637224#comment-16637224
] 

ASF GitHub Bot commented on CB-13502:
-------------------------------------

jh3141 opened a new pull request #152: CB-13502: (android) Implementation of setRate method
for Android Marshmallow and later
URL: https://github.com/apache/cordova-plugin-media/pull/152
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### What does this PR do?
   
   Support the "setRate" method already supported on iOS for Android Marshmallow devices (API
23) or later.
   
   ### What testing has been done on this change?
   
   Tested manually on two devices running different vendor versions of Android 6.0.  
   No automated test provided, as I can't see how to restrict the test environment such that
the test only runs on Android versions that support the feature.  I imagine somebody more
familiar than myself can easily update media.spec.24 to reflect the change.
   
   ### Checklist
   - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Android - add support for "setRate" method already available on iOS
> -------------------------------------------------------------------
>
>                 Key: CB-13502
>                 URL: https://issues.apache.org/jira/browse/CB-13502
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-media
>            Reporter: Julian Hall
>            Priority: Minor
>
> The iOS media plugin supports a method "setRate" which changes the playback rate.  Android
has support for this feature in the MediaPlayer class used by the media plugin since API version
23 (Marshmallow), therefore supporting this method there is very easy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message