cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
Date Wed, 03 Oct 2018 16:14:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637128#comment-16637128
] 

ASF GitHub Bot commented on CB-14024:
-------------------------------------

janpio closed pull request #265: CB-14024 Take into account statusbar height when toolbar
is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index a581472dd..e79b08922 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -885,8 +885,8 @@ - (float) getStatusBarOffset {
 }
 
 - (void) rePositionViews {
-    if ([_browserOptions.toolbarposition isEqualToString:kInAppBrowserToolbarBarPositionTop])
{
-        [self.webView setFrame:CGRectMake(self.webView.frame.origin.x, TOOLBAR_HEIGHT, self.webView.frame.size.width,
self.webView.frame.size.height)];
+    if ((_browserOptions.toolbar) && ([_browserOptions.toolbarposition isEqualToString:kInAppBrowserToolbarBarPositionTop]))
{
+        [self.webView setFrame:CGRectMake(self.webView.frame.origin.x, TOOLBAR_HEIGHT + [self
getStatusBarOffset], self.webView.frame.size.width, self.webView.frame.size.height)];
         [self.toolbar setFrame:CGRectMake(self.toolbar.frame.origin.x, [self getStatusBarOffset],
self.toolbar.frame.size.width, self.toolbar.frame.size.height)];
     }
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Doesn't have into account statusbar height when toolbar is enabled
> ------------------------------------------------------------------
>
>                 Key: CB-14024
>                 URL: https://issues.apache.org/jira/browse/CB-14024
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>    Affects Versions: cordova-ios 4.5.0
>            Reporter: Humberto Alfonso Díaz
>            Priority: Major
>              Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage to not
show properly on the header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message