cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
Date Wed, 03 Oct 2018 16:14:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637130#comment-16637130
] 

ASF GitHub Bot commented on CB-14024:
-------------------------------------

humbertuning opened a new pull request #265: CB-14024 Take into account statusbar height when
toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
 
 
   ### Platforms affected
   ios
   
   ### What does this PR do?
   
   Solves the problem with the webs that are not shown properly when toolbar is enabled on
top:
   
   `this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");`
   
   ### What testing has been done on this change?
   It was tested on ios devices using the above configuration
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Doesn't have into account statusbar height when toolbar is enabled
> ------------------------------------------------------------------
>
>                 Key: CB-14024
>                 URL: https://issues.apache.org/jira/browse/CB-14024
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>    Affects Versions: cordova-ios 4.5.0
>            Reporter: Humberto Alfonso Díaz
>            Priority: Major
>              Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage to not
show properly on the header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message