From issues-return-98474-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org Wed Apr 22 21:42:34 2020 Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id EF22F19FA2 for ; Wed, 22 Apr 2020 21:42:33 +0000 (UTC) Received: (qmail 56917 invoked by uid 500); 22 Apr 2020 21:42:33 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 56902 invoked by uid 500); 22 Apr 2020 21:42:33 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 56890 invoked by uid 99); 22 Apr 2020 21:42:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2020 21:42:33 +0000 From: =?utf-8?q?GitBox?= To: issues@cordova.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcordova-plugin-splashscreen=5D_SchnWalter_commente?= =?utf-8?q?d_on_a_change_in_pull_request_=23206=3A_Enable_colors_Android_for?= =?utf-8?q?_status_bar_and_navigation_bar?= Message-ID: <158759175325.3807.2804341390328309614.asfpy@gitbox.apache.org> Date: Wed, 22 Apr 2020 21:42:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: SchnWalter commented on a change in pull request #206: URL: https://github.com/apache/cordova-plugin-splashscreen/pull/206#discussion_r413353431 ########## File path: src/android/SplashScreen.java ########## @@ -307,12 +311,45 @@ public void run() { // Create and show the dialog splashDialog = new Dialog(context, android.R.style.Theme_Translucent_NoTitleBar); + splashWindow = splashDialog.getWindow(); // check to see if the splash screen should be full screen if ((cordova.getActivity().getWindow().getAttributes().flags & WindowManager.LayoutParams.FLAG_FULLSCREEN) == WindowManager.LayoutParams.FLAG_FULLSCREEN) { splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN, WindowManager.LayoutParams.FLAG_FULLSCREEN); } + + // Inspirated in https://github.com/apache/cordova-plugin-splashscreen/pull/124/files Review comment: No need to have this in code, it's already in the PR. P.S. Thanks for the work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org