cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-android] fserb opened a new pull request #983: Remove gradle.daemon from default forced settings
Date Mon, 01 Jun 2020 14:31:19 GMT

fserb opened a new pull request #983:
URL: https://github.com/apache/cordova-android/pull/983


   ### Platforms affected
   
   All.
   
   ### Motivation and Context
   
   https://github.com/apache/cordova-android/issues/982
   
   ### Description
   
   This removes the forced setting of `gradle.daemon` to be true. Because gradle does daemon
by default, this won't impact behavior. Except that now if users set gradle.daemon to false,
it will respect that instead of overwriting.
   
   In theory there's still a bad behavior in the code of not allowing defaults to be overwritten
at all, but it's beyond the scope of this PR.
   
   
   ### Testing
   
   `npm test` passes (and leaves a daemon behind).
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform
(e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and
used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message