cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-browser] raphinesse opened a new pull request #98: Inline browser_parser into Api
Date Wed, 03 Jun 2020 13:48:23 GMT

raphinesse opened a new pull request #98:
URL: https://github.com/apache/cordova-browser/pull/98


   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Reduce (unused) code.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   - Remove unused stuff from `browser_parser`
   - Inline remaining two methods from `browser_parser` into `Api`
   
   This removes the property `parser` from `Api` instances. AFAIK this prop is not documented,
so I'd consider it private. But if we would consider it public, this PR would be a major change.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   I ran `npm t`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message