cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #670: fix(android): Declare CAMERA permission
Date Mon, 05 Oct 2020 15:18:57 GMT

jcesarmobile commented on pull request #670:
URL: https://github.com/apache/cordova-plugin-camera/pull/670#issuecomment-703701240


   The plugin is supposed to request the permission only if the permission is present, if
that's not working properly it should be fixed instead of adding the permission. 
   If we are adding the permission then the code that checks if the permissions is present
should be removed because it will always be present, but I think we should revert this, I
don't think it's not good to add unneeded permissions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message