cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-ios] dpogue opened a new pull request #1005: Fix BackgroundColor parsing for lowercase letters
Date Wed, 07 Oct 2020 22:05:28 GMT

dpogue opened a new pull request #1005:
URL: https://github.com/apache/cordova-ios/pull/1005


   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   The guy who implemented this background colour parsing code forgot that lowercase letters
existed when writing the regex 🙄
   ([aka, me](https://github.com/apache/cordova-ios/pull/896))
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Adds support for lowercase hex characters in `BackgroundColor` preference parsing, along
with appropriate tests.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Added additional test cases with lowercase characters.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message