From crunch-dev-return-1594-apmail-incubator-crunch-dev-archive=incubator.apache.org@incubator.apache.org Mon Dec 3 18:17:58 2012 Return-Path: X-Original-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87A93D693 for ; Mon, 3 Dec 2012 18:17:58 +0000 (UTC) Received: (qmail 93377 invoked by uid 500); 3 Dec 2012 18:17:58 -0000 Delivered-To: apmail-incubator-crunch-dev-archive@incubator.apache.org Received: (qmail 93340 invoked by uid 500); 3 Dec 2012 18:17:58 -0000 Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: crunch-dev@incubator.apache.org Delivered-To: mailing list crunch-dev@incubator.apache.org Received: (qmail 93331 invoked by uid 99); 3 Dec 2012 18:17:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 18:17:58 +0000 Date: Mon, 3 Dec 2012 18:17:58 +0000 (UTC) From: "Matthias Friedrich (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: <1713282117.54265.1354558678389.JavaMail.jiratomcat@arcas> In-Reply-To: <1092090385.50854.1354458358317.JavaMail.jiratomcat@arcas> Subject: [jira] [Resolved] (CRUNCH-122) Reduce visibility of implementation classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Friedrich resolved CRUNCH-122. --------------------------------------- Resolution: Fixed Fix Version/s: 0.5.0 Done. Compared to 0.3.0 we have reduced our published interface by 50% (if we don't count deprecated stuff). Cool :) > Reduce visibility of implementation classes > ------------------------------------------- > > Key: CRUNCH-122 > URL: https://issues.apache.org/jira/browse/CRUNCH-122 > Project: Crunch > Issue Type: Improvement > Affects Versions: 0.4.0 > Reporter: Matthias Friedrich > Assignee: Matthias Friedrich > Priority: Trivial > Fix For: 0.5.0 > > Attachments: CRUNCH-122-Make-impl-classes-package-private.patch, CRUNCH-122-v2.patch, CRUNCH-122-v3.patch > > > There are a few implementation classes that are used only from within their home package. Thus, they should be package-private instead of public, which also hides them from javadoc. Most of these classes aren't from our set of "published" packages anyway but it's good style to hide them if we can. We can also make inner DoFns private if there is a static factory method for them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira