crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-157) Mark the setContext function in the DoFn class as final
Date Sun, 03 Feb 2013 18:54:12 GMT


Brock Noland commented on CRUNCH-157:

I prefer the later approach as opposed marking setContext final. It seems like every time
a class or method is marked final someone bumps into that restriction, often during unit testing.
> Mark the setContext function in the DoFn class as final
> -------------------------------------------------------
>                 Key: CRUNCH-157
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-157.patch, CRUNCH-157-sep.patch
> We often use a pattern of nested DoFns-- DoFns that are composed of operations on other
DoFns. There is currently an ambiguity around the right way to initialize those DoFns, since
it can be done either via overriding the initialize() or the setContext() methods in DoFn.
We should mark setContext as final in order to remove the ambiguity and fix the instances
in Crunch core where we override setContext() instead of initialize().

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message