From dev-return-1697-apmail-datafu-dev-archive=datafu.apache.org@datafu.incubator.apache.org Sun Feb 19 05:24:27 2017 Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C858C196CC for ; Sun, 19 Feb 2017 05:24:27 +0000 (UTC) Received: (qmail 60195 invoked by uid 500); 19 Feb 2017 05:24:27 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 60150 invoked by uid 500); 19 Feb 2017 05:24:27 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 60138 invoked by uid 99); 19 Feb 2017 05:24:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Feb 2017 05:24:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 530E01A0252 for ; Sun, 19 Feb 2017 05:24:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.48 X-Spam-Level: X-Spam-Status: No, score=0.48 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id jfclwaYxpyka for ; Sun, 19 Feb 2017 05:24:25 +0000 (UTC) Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com [209.85.218.51]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A143A5F2C3 for ; Sun, 19 Feb 2017 05:24:24 +0000 (UTC) Received: by mail-oi0-f51.google.com with SMTP id 2so1971133oif.0 for ; Sat, 18 Feb 2017 21:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=oQDEyM0HleAqcdEKaNq8M0A+izL9kcPGDWU3zwvkRIY=; b=E5RsCdIzWmNu6TxBS82QxQ9SiZsZFTGso/TgnHfsjRmiz1nxWpj/xceoRIcA8CWxRS vPlJGrKXOOADHEULGhD7PgKXFjVBP21P5f/NhngUOBDSAcOLAc9RLZ5aQcJvYyqkI2S2 DqP1rkyx5lZjuxXdRhQCwWC8doiKmTOlwiFZop9jRbBNTnCaXXLDJFKsf50vFVfyjXSA kH4XAm6ehuoOlWFNsrLlLbRfj2pWGzO/rcCMkggrAR3JxnsbvyCmaEDD1V7/d7GaJYCX HtYOAH+kpggsvSg34UcmaGC7Ma2hDpLubRsYq5VhP2cIgo0vKWBwkyZym8XgsjNaiv1Y ViwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=oQDEyM0HleAqcdEKaNq8M0A+izL9kcPGDWU3zwvkRIY=; b=SPTMbLVJ46vah916J9nzleHFlDxbFgF7xZM/bAlKHzkVy53/tMQ31utqzfFpEzIXVs PJ9vyKBmRV17tVxWwEI4U4ad70yrwqA90WNHGd5AOluhmeANiGMZGslwyRJ7bXaiPEIf ixOBjL1iRmmdLCKSdytwA7vbtjswbAzMLBJ0kFB0Gh7iYr31mnkpDbMWNvaGbF5jnCm4 Hnb9NVl6j5twMA6Xv0NmUeV2Hc+Zu+Ui8N+ieyrHX8oBs55Cp14oFGVEKLTgsozvTRCY eyXG/qLabkk1Pbdm31vZ2izB6E4/+Sfr4o923qm31x32Z9L7kXdGXj2lzU3VVMKU6cuJ 1vpw== X-Gm-Message-State: AMke39ln/5LQhizWOJ5ywXYZSnYDN32F5tFX5q3jHhhHoJvEIL9rvkd4j1/xQAiIOPz2UFaoq2oPLD0wRZYJ1w== X-Received: by 10.202.192.2 with SMTP id q2mr8260643oif.121.1487481862431; Sat, 18 Feb 2017 21:24:22 -0800 (PST) MIME-Version: 1.0 Sender: shaposhnik@gmail.com Received: by 10.182.223.16 with HTTP; Sat, 18 Feb 2017 21:24:21 -0800 (PST) In-Reply-To: References: <622E090B-FBCB-4DF7-8B96-2495269B77AD@classsoftware.com> <396AF9B8-8E5D-4D1F-B1BF-F6B66B34236B@classsoftware.com> <51A64700-7BD1-400E-B557-370986DF4D0A@classsoftware.com> <33D4E9D4-6C90-4F7D-853D-29D926B17248@classsoftware.com> From: Roman Shaposhnik Date: Sat, 18 Feb 2017 21:24:21 -0800 X-Google-Sender-Auth: PhU1oVKsLrPYGZPC9TcdKTCTmBs Message-ID: Subject: Re: [DISCUSS] Datafu graduation from the Incubator To: "dev@datafu.incubator.apache.org" Content-Type: text/plain; charset=UTF-8 On Thu, Feb 16, 2017 at 9:44 PM, Matthew Hayes wrote: > Following up on the LICENSE/NOTICE file issues in the binary artifacts, I > have prepared a patch that includes them in the artifacts, as well as the > DISCLAIMER: > > https://issues.apache.org/jira/browse/DATAFU-121 > https://reviews.apache.org/r/56779/ > > Justin and Roman, if you have time can you review these changes? +1. Manually verified your change and the correct META-INF content was observed for both jars > Feedback > from others is welcome too. I'll explain how I prepared these: > > 1) Both datafu-hourglass and datafu-pig include LICENSE, NOTICE, and > DISCLAIMER files under META-INF inside the JARs. The DISCLAIMER is the > same for each. For the the other two files they are different. > 2) datafu-hourglass JAR does not bundle any dependencies, so the LICENSE > and NOTICE files are boilerplate. Makes sense > 3) datafu-pig JAR bundles several Apache-2.0-licensed JARs (and no > non-Apache-2.0 licensed JARs). I reviewed the LICENSE and NOTICE files for > each of the bundled dependencies. The only case I found where there was a > non-boilerplate LICENSE/NOTICE provided was Apache commons-math. I copied > the NOTICE and LICENSE contents to the datafu-pig JAR's NOTICE and LICENSE > files, respectively. I manually compared these two and it looks OK to me. > 4) I disabled generation of sources and javadoc JARs to avoid the build > issues I was experiencing trying to package these LICENSE and NOTICE > files. We can enable these later once the issues are resolved. Sounds good. Thanks, Roman.