db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r1621216 - /db/derby/code/trunk/java/client/org/apache/derby/jdbc/BasicClientDataSource40.java
Date Thu, 28 Aug 2014 22:09:08 GMT
Author: dag
Date: Thu Aug 28 22:09:08 2014
New Revision: 1621216

URL: http://svn.apache.org/r1621216
Log:
DERBY-6620 Network client DataSources silently swallow SecurityExceptions when trying to read
the tracing properties

Added explanatory comments in the source where we swallow the
SecurityException.

Modified:
    db/derby/code/trunk/java/client/org/apache/derby/jdbc/BasicClientDataSource40.java

Modified: db/derby/code/trunk/java/client/org/apache/derby/jdbc/BasicClientDataSource40.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/jdbc/BasicClientDataSource40.java?rev=1621216&r1=1621215&r2=1621216&view=diff
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/jdbc/BasicClientDataSource40.java (original)
+++ db/derby/code/trunk/java/client/org/apache/derby/jdbc/BasicClientDataSource40.java Thu
Aug 28 22:09:08 2014
@@ -643,7 +643,10 @@ public class BasicClientDataSource40 
 
 
     /**
-     * Read the value of the passed system property.
+     * Read the value of the passed system property. If we are running under
+     * the Java security manager and permission to read the property is 
+     * missing,a null is returned, and no diagnostic is given (DERBY-6620).
+     * 
      * @param key name of the system property
      * @return value of the system property, null if there is no
      *         permission to read the property
@@ -658,6 +661,8 @@ public class BasicClientDataSource40 
                         // does not have permission to read the property, so
                         // if a security exception occurs, just return null
                         // and continue with the connection.
+                        // See also the discussion in DERBY-6620 on why we do
+                        // not write a warning message on the console here.
                         return null;
                     }
                 }



Mime
View raw message