From api-return-585-apmail-directory-api-archive=directory.apache.org@directory.apache.org Wed Mar 4 17:22:33 2015 Return-Path: X-Original-To: apmail-directory-api-archive@minotaur.apache.org Delivered-To: apmail-directory-api-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 514DB17C64 for ; Wed, 4 Mar 2015 17:22:33 +0000 (UTC) Received: (qmail 44818 invoked by uid 500); 4 Mar 2015 17:22:33 -0000 Delivered-To: apmail-directory-api-archive@directory.apache.org Received: (qmail 44782 invoked by uid 500); 4 Mar 2015 17:22:33 -0000 Mailing-List: contact api-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: api@directory.apache.org Delivered-To: mailing list api@directory.apache.org Received: (qmail 44765 invoked by uid 99); 4 Mar 2015 17:22:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2015 17:22:32 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates 209.85.212.182 as permitted sender) Received: from [209.85.212.182] (HELO mail-wi0-f182.google.com) (209.85.212.182) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2015 17:22:06 +0000 Received: by widem10 with SMTP id em10so30466229wid.0 for ; Wed, 04 Mar 2015 09:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=Te60Gq9+npwYHQZbpc6qH3jcwExXwLWOGxW9IVhbkak=; b=xFrsv4XC19dv9MWVQh6KOzeWeRuMzsIZEt+6y7V+xnWv+zJMgKP7Lx5mp+75oaR9gG pOL0SMElIVs/L4g8b2OY6LCMeM616KapsZr62Lm8ZTzpZD6a+QQyYJv53bA0VU1I6AFM 5UTCapac6bp+7wmNskQNUORotXAxq7DEsFzkHUY7BqrvoIsFP3eDa/MxjpXajq2rMM23 vOhuyeHFs5hLDds1gMnD07CR1vcFGDxFDKTWaCovKdSk2EiMpETgEft577LL2Sg6065C +bmbf0+ktViGV9M0Zt2cnBEZbPgS6ys+T1xOVkuAZVHXlmZ8IFSUCFo5VdW66oeSogVH t/qA== X-Received: by 10.180.83.69 with SMTP id o5mr56156855wiy.48.1425489724880; Wed, 04 Mar 2015 09:22:04 -0800 (PST) Received: from [192.168.1.15] (AMontsouris-651-1-71-121.w90-24.abo.wanadoo.fr. [90.24.182.121]) by mx.google.com with ESMTPSA id gm2sm7980989wib.5.2015.03.04.09.22.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 09:22:03 -0800 (PST) Message-ID: <54F73F37.9040508@gmail.com> Date: Wed, 04 Mar 2015 18:21:59 +0100 From: =?UTF-8?B?RW1tYW51ZWwgTMOpY2hhcm55?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: api@directory.apache.org Subject: Re: isHumanReadable in LdapSyntax References: <54F7301F.1060108@evolveum.com> In-Reply-To: <54F7301F.1060108@evolveum.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Le 04/03/15 17:17, Radovan Semancik a =C3=A9crit : > Hi, > > The current code of class LdapSyntax, method isHumanReadable seems to > return false by default (line 145). However the comment indicates > that it should default to string which is human readable. So the line > should be probably "return true" and not "return false". This seemed > to me as an obvious bug. Indeed. It's even worse : we check that the extensions contain the MetaSchemaConstants.X_NOT_HUMAN_READABLE_AT value, which is "x-not-humane-readable" (lower case) when the flag is itself uper case :/= We have to make this part case-insensitive ... > > But when I've changed it to "return true" then the > SchemaObjectRendererTest fails ... in a quite strange way (NPE).=20 Hmmm, not for me. > I do not feel to be very strong here and I'm not really sure what I'm > doing. Could anyone please have a look and help me out? Sure, I'm having a look at this mess atm.