directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <>
Subject [jira] Updated: (DIRSERVER-732) FilterParser initialized for each search
Date Tue, 20 Mar 2007 22:14:32 GMT


Emmanuel Lecharny updated DIRSERVER-732:

The "offending" code is in There is
a member which is initializing the filter each time we create a new ServerDirContext :
    FilterParserImpl filterParser = new FilterParserImpl();
(line 730)

> FilterParser initialized for each search
> ----------------------------------------
>                 Key: DIRSERVER-732
>                 URL:
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>            Reporter: Emmanuel Lecharny
>            Priority: Minor
>             Fix For: 1.5.1
> The FilterParserImpl is initialized ecery time we do a search, when it should only be
initialized once, and be synchronized if we use it. The cost of this initialization, even
if not important, represent around 1% of all the CPU.
> Another point I would raise is : do we need to parse filters on the server ? At first
glance, it seems that its usage is only necessary when dealing with persistent searches, but
even then, the received request is supposed to contains a preparsed form of the filter, which
is stored in a Filter structure. I may be wrong, as I didn't have look at the code very thouroughly,
but it seems strange to me ...

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message