directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lécharny <elecha...@gmail.com>
Subject Re: $NON-NLS-1$ usage...
Date Mon, 04 May 2015 19:18:15 GMT
Le 04/05/15 19:30, Stefan Seelmann a écrit :
> On 05/04/2015 02:37 PM, Emmanuel Lécharny wrote:
>> Hi guys,
>>
>> in Studio, we have thousands of "// $NON-NLS-1$" comments in Studio's
>> code. Those comments were used to shut down some warnings in eclipse.
>> This is now totally superflouous, as we already have ignored such a
>> warning in the formatter we are using.
>>
>> I woudl suggest we remove all those comments in the code.
>>
>> Thoughts ?
>>
> They have another meaning: They are marker of the "Externalize Strings"
> tool/wizard. So if we want to continue to support NLS I think usage of
> the tool and the markers are essential.
Ah, good to know.

What about the markers that are after Strings that are already read from
Properties, like in :
        toolkit.createLabel( serverIdComposite, Messages.getString(
"OpenLDAPOverviewPage.ServerID" ) ); //$NON-NLS-1$
?

Also should I add it when I use a String ?

Thanks !


Mime
View raw message