directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <>
Subject [jira] [Commented] (DIRKRB-669) Authorization data needed by backend code create a circular project reference
Date Thu, 16 Nov 2017 15:03:00 GMT


Colm O hEigeartaigh commented on DIRKRB-669:

Re the 2nd point, here is the issue:

+        if (msgType == KrbMessageType.TGS_REQ) {
+        TgsRequest tgsRequest = (TgsRequest) kdcRequest;
+            clientRequest.setTgt(tgsRequest.getTgtTicket());

The second line needs to be indented to the right to align with "clientRequest".

> Authorization data needed by backend code create a circular project reference
> -----------------------------------------------------------------------------
>                 Key: DIRKRB-669
>                 URL:
>             Project: Directory Kerberos
>          Issue Type: Improvement
>            Reporter: Gerard Gagliano
>            Assignee: Gerard Gagliano
>         Attachments: KrbClient.patch, KrbClientNoMainPom.patch
> Making changes necessitated by the introduction of the KdcClientRequest class and the
associated calling parameter changes has presented a circular reference in kerb-core and krb-identity.

> Many data items needed by the authorization data backend code are not included in the
KdcClientRequest class as defined in the 1.1.0-SNAPSHOT.  Modification of this class to include
the necessary data items includes a reference to the KrbIdentity class.
> This creates a circular dependency between the kerb-core project and the kerb-identity
project.  The circular dependency can be resolved by moving KrbIdentity from kerb-identity
to kerb-common.  At the same time, KdcClientRequest can be moved to the same location because
its current location (….kerb.type.kdc) includes only ASN1 classes.
> Moving the classes as follows resolves the circular dependency:
>    KdcClientRequest from kerb-core, and
>    KrbIdentity from kerb-identity
>    To kerb-common — package org.apache.kerby.kerberos.kerb.request

This message was sent by Atlassian JIRA

View raw message