From dev-return-56798-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Thu Nov 16 09:55:08 2017 Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A84FE17E32 for ; Thu, 16 Nov 2017 09:55:08 +0000 (UTC) Received: (qmail 99471 invoked by uid 500); 16 Nov 2017 09:55:08 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 99417 invoked by uid 500); 16 Nov 2017 09:55:08 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 99407 invoked by uid 99); 16 Nov 2017 09:55:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 09:55:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8EF0E180784 for ; Thu, 16 Nov 2017 09:55:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Wm7xonfcmXt0 for ; Thu, 16 Nov 2017 09:55:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1EBE85FCFB for ; Thu, 16 Nov 2017 09:55:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5A246E0295 for ; Thu, 16 Nov 2017 09:55:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0ED26240D2 for ; Thu, 16 Nov 2017 09:55:00 +0000 (UTC) Date: Thu, 16 Nov 2017 09:55:00 +0000 (UTC) From: "Colm O hEigeartaigh (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRKRB-669) Authorization data needed by backend code create a circular project reference MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRKRB-669?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1625= 5032#comment-16255032 ]=20 Colm O hEigeartaigh commented on DIRKRB-669: -------------------------------------------- Looks good to me. Two minor changes please: 1) Fix the spacing in KrbIdentity. The instance variable names are all alig= ned on a column - the project doesn't use that style. eg. change private PrincipalName principal; to private PrincipalName principal; 2) There is an indentation issue on line 302 of TicketIssuer > Authorization data needed by backend code create a circular project refer= ence > -------------------------------------------------------------------------= ---- > > Key: DIRKRB-669 > URL: https://issues.apache.org/jira/browse/DIRKRB-669 > Project: Directory Kerberos > Issue Type: Improvement > Reporter: Gerard Gagliano > Assignee: Gerard Gagliano > Attachments: KrbClient.patch, KrbClientNoMainPom.patch > > > Making changes necessitated by the introduction of the KdcClientRequest c= lass and the associated calling parameter changes has presented a circular = reference in kerb-core and krb-identity.=20 > Many data items needed by the authorization data backend code are not inc= luded in the KdcClientRequest class as defined in the 1.1.0-SNAPSHOT. Modi= fication of this class to include the necessary data items includes a refer= ence to the KrbIdentity class. > This creates a circular dependency between the kerb-core project and the = kerb-identity project. The circular dependency can be resolved by moving K= rbIdentity from kerb-identity to kerb-common. At the same time, KdcClientR= equest can be moved to the same location because its current location (=E2= =80=A6.kerb.type.kdc) includes only ASN1 classes. > Moving the classes as follows resolves the circular dependency: > KdcClientRequest from kerb-core, and > KrbIdentity from kerb-identity > To kerb-common =E2=80=94 package org.apache.kerby.kerberos.kerb.reques= t -- This message was sent by Atlassian JIRA (v6.4.14#64029)