[ https://issues.apache.org/jira/browse/DIRKRB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255032#comment-16255032 ] 

Colm O hEigeartaigh commented on DIRKRB-669:
--------------------------------------------

Looks good to me. Two minor changes please:

1) Fix the spacing in KrbIdentity. The instance variable names are all aligned on a column - the project doesn't use that style.

eg. change

private PrincipalName                            principal;

to

private PrincipalName principal;

2) There is an indentation issue on line 302 of TicketIssuer

> Authorization data needed by backend code create a circular project reference
> -----------------------------------------------------------------------------
>
>                 Key: DIRKRB-669
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-669
>             Project: Directory Kerberos
>          Issue Type: Improvement
>            Reporter: Gerard Gagliano
>            Assignee: Gerard Gagliano
>         Attachments: KrbClient.patch, KrbClientNoMainPom.patch
>
>
> Making changes necessitated by the introduction of the KdcClientRequest class and the associated calling parameter changes has presented a circular reference in kerb-core and krb-identity. 
> Many data items needed by the authorization data backend code are not included in the KdcClientRequest class as defined in the 1.1.0-SNAPSHOT.  Modification of this class to include the necessary data items includes a reference to the KrbIdentity class.
> This creates a circular dependency between the kerb-core project and the kerb-identity project.  The circular dependency can be resolved by moving KrbIdentity from kerb-identity to kerb-common.  At the same time, KdcClientRequest can be moved to the same location because its current location (….kerb.type.kdc) includes only ASN1 classes.
> Moving the classes as follows resolves the circular dependency:
>    KdcClientRequest from kerb-core, and
>    KrbIdentity from kerb-identity
>    To kerb-common — package org.apache.kerby.kerberos.kerb.request



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)