directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [directory-kerby] coheigea commented on a change in pull request #45: DIRKRB-740
Date Fri, 08 May 2020 07:30:53 GMT

coheigea commented on a change in pull request #45:
URL: https://github.com/apache/directory-kerby/pull/45#discussion_r421990627



##########
File path: kerby-backend/ldap-backend/src/main/java/org/apache/kerby/kerberos/kdc/identitybackend/LdapIdentityBackend.java
##########
@@ -51,13 +51,18 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.HashMap;
 
 /**
  * An LDAP based backend implementation.
  */
 public class LdapIdentityBackend extends AbstractIdentityBackend {
+    private int currentConnectionIndex = 0;
+    private Map<String, LdapConnection> connections = new HashMap<>();

Review comment:
       Should this be ConcurrentHashMap for thread-safety?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Mime
View raw message