directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel L├ęcharny (Jira) <j...@apache.org>
Subject [jira] [Commented] (DIRSERVER-2308) Moddn overrides existing entry
Date Mon, 04 May 2020 07:34:00 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098741#comment-17098741
] 

Emmanuel L├ęcharny commented on DIRSERVER-2308:
----------------------------------------------

Ok, seems like something is wrong...

I just added a unit test for the moddn operation, and it works just fine (ie, the Entry Already
Exists exception is properly thrown). The trick is that it's ok when the {{rename}} operation
is being called internally (ie when {{newSuperior}} is null.)

Here is the code :

{code:java}
    @Override
    public void rename( RenameOperationContext renameContext ) throws LdapException
    {
        Dn dn = renameContext.getDn();

        if ( dn.equals( subschemSubentryDn ) )
        {
            throw new LdapUnwillingToPerformException( ResultCodeEnum.UNWILLING_TO_PERFORM,
I18n.err( I18n.ERR_255,
                subschemSubentryDn, subschemSubentryDn ) );
        }

        // check to see if target entry exists
        Dn newDn = renameContext.getNewDn();

        HasEntryOperationContext hasEntryContext = new HasEntryOperationContext( renameContext.getSession(),
newDn );
        hasEntryContext.setPartition( renameContext.getPartition() );
        hasEntryContext.setTransaction( renameContext.getTransaction() );

        if ( nexus.hasEntry( hasEntryContext ) )
        {
            // Ok, the target entry already exists.
            // If the target entry has the same name than the modified entry, it's a rename
on itself,
            // we want to allow this.
            if ( !newDn.equals( dn ) )
            {
                throw new LdapEntryAlreadyExistsException( I18n.err( I18n.ERR_250_ENTRY_ALREADY_EXISTS,
newDn.getName() ) );
            }
        }
...
{code}

So remains the case where we provide a new superior. I'm going to check.

> Moddn overrides existing entry
> ------------------------------
>
>                 Key: DIRSERVER-2308
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-2308
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: ldap
>    Affects Versions: 2.0.0.AM26
>            Reporter: Stefan Seelmann
>            Priority: Major
>             Fix For: 2.0.0.AM27
>
>
> Moddn operation where the new DN matches an already existing entry overrides that entry
> {noformat}
> dn: uid=bar,dc=example,dc=com
> changetype: add
> objectClass: inetOrgPerson
> objectClass: organizationalPerson
> objectClass: person
> objectClass: top
> uid: bar
> cn: bar
> sn: bar
> dn: uid=foo,dc=example,dc=com
> changetype: add
> objectClass: inetOrgPerson
> objectClass: organizationalPerson
> objectClass: person
> objectClass: top
> uid: foo
> cn: foo
> sn: foo
> dn: uid=bar,dc=example,dc=com
> changetype: moddn
> newrdn: uid=foo
> deleteoldrdn: 1
> newsuperior: dc=example,dc=com
> {noformat}
> Result is that uid=bar is gone and uid=foo has attributes of bar.
> {noformat}
> dn: uid=foo,dc=example,dc=com
> objectClass: inetOrgPerson
> objectClass: organizationalPerson
> objectClass: person
> objectClass: top
> cn: bar
> sn: bar
> uid: foo
> {noformat}
> Expected: Error 68 (entryAlreadyExists)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Mime
View raw message