From dev-return-61750-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Fri Sep 11 12:25:27 2020 Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 83B2D1A492 for ; Fri, 11 Sep 2020 12:25:27 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 379EE123686 for ; Fri, 11 Sep 2020 12:25:27 +0000 (UTC) Received: (qmail 61627 invoked by uid 500); 11 Sep 2020 12:25:27 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 61599 invoked by uid 500); 11 Sep 2020 12:25:26 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@directory.apache.org Received: (qmail 61588 invoked by uid 99); 11 Sep 2020 12:25:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2020 12:25:26 +0000 From: =?utf-8?q?GitBox?= To: dev@directory.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bdirectory-server=5D_kwart_commented_on_a_change_in?= =?utf-8?q?_pull_request_=2340=3A_DIRSERVER-2326_Use_Bouncy_Castle_to_genera?= =?utf-8?q?te_certificates?= Message-ID: <159982712667.32230.5293011009223405248.asfpy@gitbox.apache.org> Date: Fri, 11 Sep 2020 12:25:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: kwart commented on a change in pull request #40: URL: https://github.com/apache/directory-server/pull/40#discussion_r487009598 ########## File path: all/pom.xml ########## @@ -163,11 +163,11 @@ true - org.bouncycastle:bcprov-jdk15on + *:* Review comment: We can keep the smaller scope, but I think we never want to include the signature files. So upgrade of a library which suddenly starts to sign its JARs wouldn't require the filter change. @coheigea So do you think we should have the smaller scope and filter the libraries with signed classes if a need comes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org For additional commands, e-mail: dev-help@directory.apache.org