directory-fortress mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shawn McKinney <smckin...@apache.org>
Subject Re: [Apache Fortress] [FC-144] Questions on implementation of Role-to-Group relationship
Date Mon, 29 Aug 2016 12:29:42 GMT

> On Aug 28, 2016, at 1:53 PM, Vyacheslav Vakhlyuev <vvakhlyuev@mirantis.com> wrote:
> 
> I've created an initial implementation of the functionality described in
> this thread.
> At the moment I pushed it to my forked copy of the main repo there:
> https://github.com/vvakhlyuev-work/directory-fortress-core/commit/098f0a37b69be2cf76fa8d6e23ef3d250ccf58fc
> Could you please review it and provide a feedback?
> 
> There's still more work to do: add REST managers, update console managers,
> add new unit-tests etc., but I want to make sure that I'm on the right way.
> Thank you in advance!

Hello Vyacheslav,

I did a quick code review and it looks like you’re on the right track.  Good work!

Thanks,
Shawn
Mime
View raw message