doris-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1289: Modify colocation creation logic
Date Fri, 14 Jun 2019 04:28:28 GMT
kangkaisen commented on a change in pull request #1289: Modify colocation creation logic
URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r293655591
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
 ##########
 @@ -4109,6 +4093,13 @@ private void createTablets(String clusterName, MaterializedIndex index,
ReplicaS
                     db.writeUnlock();
                 }
             }
+
+            // firstColocateTable is true, means this may be the first table of colocation
group,
+            // or this is just a normal table.
+            boolean firstColocateTable = backendsPerBucketSeq == null || backendsPerBucketSeq.isEmpty();
 
 Review comment:
   the variate name `firstColocateTable ` would better change: shouldChooseBackendsRandom?
 chooseBackendsFromColocateMeta?  or  isColocateChildTable ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org


Mime
View raw message