doris-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-doris] morningman commented on a change in pull request #1289: Modify colocation creation logic
Date Fri, 14 Jun 2019 08:18:30 GMT
morningman commented on a change in pull request #1289: Modify colocation creation logic
URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r293700600
 
 

 ##########
 File path: fe/src/test/java/org/apache/doris/catalog/ColocateTableTest.java
 ##########
 @@ -477,62 +377,4 @@ public void testDistributionColumnsType() throws Exception {
 
         catalog.createTable(childStmt);
     }
-
-    @Test
-    public void testParentTableNotExist() throws Exception {
-        testParentTableNotExist("t8");
-    }
-
-    @Test
-    public void testParentTableNotExistCaseSensitive() throws Exception {
-        testParentTableNotExist(tableName1.toUpperCase());
-    }
-
-    private void testParentTableNotExist(String tableName) throws Exception {
-        Map<String, String> properties = new HashMap<String, String>();
-        properties.put(PropertyAnalyzer.PROPERTIES_COLOCATE_WITH, tableName);
-
-        int bucketNum = 1;
-        CreateTableStmt parentStmt = new CreateTableStmt(false, false, dbTableName1, columnDefs,
"olap",
-                new KeysDesc(KeysType.AGG_KEYS, columnNames), null,
-                new HashDistributionDesc(bucketNum, Lists.newArrayList("key1")), properties,
null);
-        parentStmt.analyze(analyzer);
-
-        expectedEx.expect(DdlException.class);
-        expectedEx.expectMessage(String.format("Colocate table '%s' no exist", tableName));
-
-        catalog.createTable(parentStmt);
-    }
-
-    @Test
-    public void testParentTableType() throws Exception {
 
 Review comment:
   Oh, actually this is not for testing if the colocate table is olap table. It is testing
if the 'colocate_with' table is a olap table. But now, 'colocate_with' points to a group,
not a table, so this test is abandoned

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org


Mime
View raw message