drill-commits mailing list archives

DRILL-5121 Fix for memory leak. Changes fieldVectorMap in ScanBatch to a CaseInsensitiveMap

close apache/drill#690


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/15b021f1
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/15b021f1
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/15b021f1

Branch: refs/heads/master
Commit: 15b021f1f4c73c08c0443fd9cae0221ae43877ba
Parents: 167f0ce
Author: karthik <kmanivannan@maprtech.com>
Authored: Mon Nov 14 10:36:53 2016 -0800
Committer: Aman Sinha <asinha@maprtech.com>
Committed: Sun Jan 8 12:28:14 2017 -0800

----------------------------------------------------------------------
 .../java/org/apache/drill/exec/physical/impl/ScanBatch.java     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/15b021f1/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
index 43fabba..ad82668 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
@@ -53,6 +53,7 @@ import org.apache.drill.exec.vector.AllocationHelper;
 import org.apache.drill.exec.vector.NullableVarCharVector;
 import org.apache.drill.exec.vector.SchemaChangeCallBack;
 import org.apache.drill.exec.vector.ValueVector;
+import org.apache.drill.common.map.CaseInsensitiveMap;
 
 import com.google.common.collect.Maps;
 
@@ -67,8 +68,8 @@ public class ScanBatch implements CloseableRecordBatch {
   private final VectorContainer container = new VectorContainer();
 
   /** Fields' value vectors indexed by fields' keys. */
-  private final Map<String, ValueVector> fieldVectorMap =
-      Maps.newHashMap();
+  private final CaseInsensitiveMap<ValueVector> fieldVectorMap =
+          CaseInsensitiveMap.newHashMap();
 
   private int recordCount;
   private final FragmentContext context;