drill-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vita...@apache.org
Subject [drill] 02/07: DRILL-6843: Update SchemaBuilder comment to match implementation
Date Thu, 15 Nov 2018 23:51:31 GMT
This is an automated email from the ASF dual-hosted git repository.

vitalii pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git

commit addc40f808806a695f601c041ae5136e2d2f18c1
Author: Paul Rogers <progers@cloudera.com>
AuthorDate: Sat Nov 10 16:15:33 2018 -0800

    DRILL-6843: Update SchemaBuilder comment to match implementation
    
    The schema builder API evolved a while back. The class provides a detailed comment to
explain usage. That comment was out of date. This fix updates the comment to match the code.
    
    closes #1533
---
 .../apache/drill/test/rowSet/schema/SchemaBuilder.java | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaBuilder.java
b/exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaBuilder.java
index 2cc82a5..51193eb 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaBuilder.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaBuilder.java
@@ -36,32 +36,32 @@ import org.apache.drill.exec.record.metadata.TupleMetadata;
  * i: BIGINT[], j: VARCHAR[][][])</tt>
  * <p>
  * Code:<pre><code>
- *     BatchSchema batchSchema = new SchemaBuilder()
+ *     TupleMetadata schema = new SchemaBuilder()
  *        .add("c", MinorType.INT)
  *        .addMap("a")
  *          .addNullable("b", MinorType.VARCHAR)
  *          .add("d", MinorType.INT)
  *          .addMap("e") // or .addMapArray("e")
  *            .add("f", MinorType.VARCHAR)
- *            .buildMap()
+ *            .resumeMap()
  *          .add("g", MinorType.INT)
- *          .buildMap()
+ *          .resumeSchema()
  *        .addUnion("h") // or .addList("h")
  *          .addType(MinorType.INT)
  *          .addMap()
  *            .add("h1", MinorType.INT)
- *            .buildNested()
+ *            .resumeUnion()
  *          .addList()
  *            .addType(MinorType.BIGINT)
- *            .buildNested()
- *          .build()
+ *            .resumeUnion()
+ *          .resumeSchema()
  *        .addArray("i", MinorType.BIGINT)
  *        .addRepeatedList("j")
  *          .addDimension()
  *            .addArray(MinorType.VARCHAR)
- *            .endDimension()
- *         .build()
- *        .build();
+ *            .resumeList()
+ *         .resumeSchema()
+ *        .buildSchema();
  * </code</pre>
  */
 


Mime
View raw message