drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Becker" <benjamin.bec...@gmail.com>
Subject Review Request: DRILL-45: Add builders for PlanProperties, LogicalPlan, Store and Scan
Date Mon, 10 Jun 2013 21:17:12 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11783/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Description
-------

Looking for validation of builder apprach.
 - Includes LogicalPlanBuilder and PlanPropertiesBuilder attached to JIRA-45; rebased to latest
execwork.
 - Includes ScanBuilder and StoreBuilder as well.

Note: One of the original builders also had a 'toBuilder()' method.  Is that something we
should add for all builders?


Diffs
-----

  sandbox/prototype/common/src/main/java/org/apache/drill/common/PlanProperties.java c532e18

  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/LogicalPlan.java
a2f2499 
  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/LogicalPlanBuilder.java
PRE-CREATION 
  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/PlanProperties.java
PRE-CREATION 
  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/Scan.java c8d396b

  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/ScanBuilder.java
PRE-CREATION 
  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/Store.java 0569b8a

  sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/StoreBuilder.java
PRE-CREATION 
  sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/LogicalPlanBuilderTest.java
PRE-CREATION 
  sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/ScanBuilderTest.java
PRE-CREATION 
  sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/StoreBuilderTest.java
PRE-CREATION 
  sandbox/prototype/common/src/test/resources/storage_engine_plan.json efde80d 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/PhysicalPlan.java
84bfc87 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/record/vector/NullableValueVector.java
692ab87 

Diff: https://reviews.apache.org/r/11783/diff/


Testing
-------


Thanks,

Ben Becker
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message