drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DRILL-75) Add JSONRecordReader
Date Mon, 17 Jun 2013 16:14:22 GMT

     [ https://issues.apache.org/jira/browse/DRILL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacques Nadeau resolved DRILL-75.
---------------------------------

    Resolution: Fixed

Good stuff!  I've applied

Applying the patch, I had a rew issues.  I've corrected them and applied but wanted to let
you know for future patches.

- You should prepare the patch using git-format-patch so we can keep commit information.
- In JSONRecordReaderTest you refer to the raw ValueVector type.  We should try to always
use parameterized declarations for generic types.
- Applying to the tip of execwork and running mvn clean test results in four test failures:
  

Tests in error:
  testChangedSchemaInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException:
exec/java-exec/src/test/resources/scan_json_test_2.json (No such file or directory)
  testSameSchemaInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException:
exec/java-exec/src/test/resources/scan_json_test_1.json (No such file or directory)
  testChangedSchemaInTwoBatches(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException:
exec/java-exec/src/test/resources/scan_json_test_2.json (No such file or directory)
  testNestedFieldInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException:
exec/java-exec/src/test/resources/scan_json_test_3.json (No such file or directory)


It looks like you were running these things with an assumption around the working path (maybe
coming from within an IDE?).  I updated them to use classpath location so that they no longer
fail.

                
> Add JSONRecordReader
> --------------------
>
>                 Key: DRILL-75
>                 URL: https://issues.apache.org/jira/browse/DRILL-75
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Timothy Chen
>            Assignee: Timothy Chen
>         Attachments: JSON_Reader.patch.5
>
>
> No repeated fields and late bind schema support yet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message