drill-dev mailing list archives

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21165/
-----------------------------------------------------------

(Updated May 8, 2014, 7:35 p.m.)


Review request for drill, Jinfeng Ni and Steven Phillips.


Changes
-------

Updated the diff with the suggested changes.


Bugs: DRILL-626
    https://issues.apache.org/jira/browse/DRILL-626


Repository: drill-git


Description
-------

If a query against an HBase table requires only a subset of columns, we should qualify the
HBase scan with these columns.

For example

    SELECT row_key, f['c1'], f['c2'], g FROM hbase.MyTable

should qualify the HBase scan as families => [g["ALL"], f["c1", "c2"]]


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/exceptions/DrillRuntimeException.java 9266cdd

  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
bcdebc3 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
aa5743f 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java
c4ac08c 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
ea1550d 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSubScan.java
ceaf23f 
  contrib/storage-hbase/src/test/java/org/apache/drill/hbase/BaseHBaseTest.java PRE-CREATION

  contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java
1911078 
  contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseProjectPushDown.java
PRE-CREATION 
  contrib/storage-hbase/src/test/resources/hbase/hbase_scan_screen_physical_column_select.json
13a2982 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScan.java
cd78bc1 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java 492dbc1

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java
0eae1da 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PrelUtil.java d69f8cf

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java f94cff8

  exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java 2972928 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaGroupScan.java
5202038 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java 4d4ec9b


Diff: https://reviews.apache.org/r/21165/diff/


Testing
-------


Thanks,

Aditya Kishore