drill-dev mailing list archives

DRILL-761: Fix IOBE while dealing with 'null' in VarBinary vector


Project: http://git-wip-us.apache.org/repos/asf/incubator-drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-drill/commit/1ba16034
Tree: http://git-wip-us.apache.org/repos/asf/incubator-drill/tree/1ba16034
Diff: http://git-wip-us.apache.org/repos/asf/incubator-drill/diff/1ba16034

Branch: refs/heads/master
Commit: 1ba1603472a0d4aa639af213f68d98229a9bbbeb
Parents: 5770568
Author: Mehant Baid <mehantr@gmail.com>
Authored: Fri May 16 13:02:46 2014 -0700
Committer: Jacques Nadeau <jacques@apache.org>
Committed: Fri May 16 13:35:35 2014 -0700

----------------------------------------------------------------------
 exec/java-exec/src/main/codegen/templates/NullableValueVectors.java | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/1ba16034/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java b/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java
index 61c488a..7cece65 100644
--- a/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java
+++ b/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java
@@ -418,6 +418,7 @@ public final class ${className} extends BaseValueVector implements <#if
type.maj
       <#if type.major != "VarLen">
       throw new UnsupportedOperationException();
       <#else>
+      if(!fillEmpties(index)) return false;
 
       boolean b1 = bits.getMutator().setSafe(index, 1);
       boolean b2 = values.getMutator().setSafe(index, value, start, length);