-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25409/#review52936
-----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/25409/#comment92171>
the first one should be drillClientImpl.hpp. Since this cpp file is mainly for the implemenation
of drillClientImpl.hpp.
Refer C++ Code guideline here
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
- Xiao Meng
On Sept. 6, 2014, 12:50 a.m., Xiao Meng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25409/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2014, 12:50 a.m.)
>
>
> Review request for drill and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-1305: C++ Client. Consume QueryState message from the Drillbit.
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClientImpl.hpp e40b2147cc7057b5c0a2b6b6f32afafed236a928
> contrib/native/client/src/clientlib/drillClientImpl.cpp 54dcdd0f1dcc1e9608b996c47fd6f61e8f0f21c2
> contrib/native/client/src/clientlib/recordBatch.cpp 17073bd6284cb5e4825cca6a6ddf5c34ee850af3
> contrib/native/client/src/include/drill/common.hpp 2113ce5e14d07ee91b6a9a34efb68ae33f617707
>
> Diff: https://reviews.apache.org/r/25409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xiao Meng
>
>
|