drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Meng" <xiaom...@gmail.com>
Subject Re: Review Request 25409: DRILL-1305: C++ Client. Consume QueryState message from the Drillbit.
Date Wed, 01 Oct 2014 18:23:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25409/#review55103
-----------------------------------------------------------



contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/25409/#comment95464>

    The query_state checking here is redudant now since it is been checked in the switch cases.


- Xiao Meng


On Sept. 29, 2014, 7:46 p.m., Xiao Meng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25409/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 7:46 p.m.)
> 
> 
> Review request for drill and Parth Chandra.
> 
> 
> Bugs: DRILL-1305
>     https://issues.apache.org/jira/browse/DRILL-1305
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-1305: C++ Client. Consume QueryState message from the Drillbit.
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/example/querySubmitter.cpp 17bec3c 
>   contrib/native/client/src/clientlib/drillClientImpl.hpp 5ac158f 
>   contrib/native/client/src/clientlib/drillClientImpl.cpp f1a165d 
>   contrib/native/client/src/clientlib/errmsgs.hpp 437335c 
>   contrib/native/client/src/clientlib/errmsgs.cpp 966cfc2 
>   contrib/native/client/src/include/drill/common.hpp 151d698 
> 
> Diff: https://reviews.apache.org/r/25409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xiao Meng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message