drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 26696: DRILL-1534: Implement UDF to expand a map into a repeated map with key, value pairs.
Date Wed, 15 Oct 2014 16:52:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26696/#review56615
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java
<https://reviews.apache.org/r/26696/#comment96999>

    As long as we're committing the code, we should put it in a place where it can be found
easily if we think it will be useful for other functions or operators. If anything just put
it in a MapUtilities class.



exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java
<https://reviews.apache.org/r/26696/#comment96996>

    Was there a reason for using if/else statements here instead of a switch on the ENUM?



exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java
<https://reviews.apache.org/r/26696/#comment97000>

    Did you use some kind of a script to generate this? or did you just write it by hand?
While there are places in the code where we have and written code for managing a bunch of
types, it would be best to just check in any automated tool you used to generate this if you
used one.



exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java
<https://reviews.apache.org/r/26696/#comment97002>

    I'm going to look into generating a parquet file with some mock data of various types
in different levels of nesting. I think there are too many places where we have code written
against a lot of types and no simple means of testing all of them in a nested setting.


- Jason Altekruse


On Oct. 15, 2014, 7:23 a.m., Mehant Baid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26696/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 7:23 a.m.)
> 
> 
> Review request for drill and Jason Altekruse.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Consider the following JSON:
> {"x":{ "y": "kevin", "z": "paul" } }
> 
> Now this UDF would transform the map 'x' in the following manner
> [ {"key":"y","value":"kevin"}, {"key":"z","value":"paul"}]
> 
> Currently this function only supports simple map as input and poses the following two
conditions on the values within the map
> 1. They should be of the same type
> 2. They can only be scalar types
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Mappify.java PRE-CREATION

>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java
PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java
2e62897 
>   exec/java-exec/src/test/resources/jsoninput/input3.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26696/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests and ran some manual tests via sqlline. 
> 
> 
> Thanks,
> 
> Mehant Baid
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message