drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aman Sinha <asi...@maprtech.com>
Subject Re: Proguard verbose output on latest master ?
Date Tue, 14 Oct 2014 23:05:58 GMT
Aditya,  thanks for those flags.  Do you want to create the JIRA for
removing it from the default build and perhaps assign it to yourself :)

On Tue, Oct 14, 2014 at 3:34 PM, Aditya <adityakishore@gmail.com> wrote:

> I agree. This could be made a part of "apache-release" profile.
>
> On Tue, Oct 14, 2014 at 3:32 PM, Jason Altekruse <altekrusejason@gmail.com
> >
> wrote:
>
> > I think the better option is to remove the proguard goal from the default
> > build. It isn't testing anything or accomplishing a useful for the dev
> team
> > to run it for every build, with or without the crazy logging. In the
> > meantime this would be useful for making the build a little faster.
> >
> > -Jason
> >
> > On Tue, Oct 14, 2014 at 3:16 PM, Aditya <adityakishore@gmail.com> wrote:
> >
> >> This commit [1] turned off the verbose output from ProGuard
> >>
> >> However, the bulk of messages are info and warning, which requires
> >> additional flags to turn off. The following patch can turn off both of
> >> these
> >>
> >>  exec/jdbc-all/pom.xml | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/exec/jdbc-all/pom.xml b/exec/jdbc-all/pom.xml
> >> index 349366b..783fa6f 100644
> >> --- a/exec/jdbc-all/pom.xml
> >> +++ b/exec/jdbc-all/pom.xml
> >> @@ -215,6 +215,8 @@
> >>            <outputDirectory>${project.build.directory}</outputDirectory>
> >>            <maxMemory>6g</maxMemory>
> >>            <options>
> >> +            <option>-dontnote</option>
> >> +            <option>-dontwarn</option>
> >>              <option>-dontobfuscate</option>
> >>              <option>-dontoptimize</option>
> >>              <option>-ignorewarnings</option>
> >>
> >> Do we want do do this?
> >>
> >> [1]
> >>
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-drill.git;a=commitdiff;h=35296501
> >>
> >> On Tue, Oct 14, 2014 at 2:32 PM, Hanifi Gunes <hgunes@maprtech.com>
> >> wrote:
> >>
> >> > Afaik proguard plugin outputs verbose messages if it is a debug build
> or
> >> > verbose switch is explicitly passed. Not sure about the recent changes
> >> > though.
> >> >
> >> >
> >> > On Tue, Oct 14, 2014 at 2:11 PM, Jason Altekruse <
> >> altekrusejason@gmail.com
> >> > >
> >> > wrote:
> >> >
> >> > > Not sure about the impact of the proguard upgrade, but I almost
> always
> >> > > cancel the build if I happen to see that output. I know if it gets
> to
> >> > that
> >> > > point that I haven't failed any tests. The only reason we have that
> in
> >> > the
> >> > > build is to make the thin jdbc jar, which most devs on the team
> aren't
> >> > > making use of right now. The longer term solution has been
> discussed,
> >> > which
> >> > > is pulling out the proguard step into a release only version of the
> >> build
> >> > > that will be run less frequently.
> >> > >
> >> > > -Jason
> >> > >
> >> > > On Tue, Oct 14, 2014 at 1:58 PM, Aman Sinha <asinha@maprtech.com>
> >> wrote:
> >> > >
> >> > > > I am seeing a whole bunch of Proguard verbose output when doing
a
> >> build
> >> > > of
> >> > > > latest 0.7 master branch.   Anyone else seeing this ?  I thought
a
> >> > prior
> >> > > > commit had fixed this but maybe the upgrade of Proguard to 5.0
> >> changed
> >> > > this
> >> > > > behavior.
> >> > > >
> >> > >
> >> >
> >>
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message