drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norris Lee" <norr...@simba.com>
Subject Re: Review Request 26672: DRILL-1533 C++ Drill Client always sets hasSchemaChanged to true for every new record batch
Date Tue, 06 Jan 2015 00:10:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26672/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 12:10 a.m.)


Review request for drill and Parth Chandra.


Changes
-------

Rebase to head, squashed commits


Repository: drill-git


Description
-------

hasSchemaChanged is always set as true for all record batches except the first one regardless
of whether the schema has changed or not, including cases where specific columns are projected,
which should never happen.


Diffs (updated)
-----

  contrib/native/client/src/clientlib/drillClientImpl.cpp 23dc407 

Diff: https://reviews.apache.org/r/26672/diff/


Testing
-------


Thanks,

Norris Lee


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message