-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26371/#review66885
-----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp
<https://reviews.apache.org/r/26371/#comment110581>
msg here is not a protobuf object (sorry that was my mistake) and so there are no has_xxx
methods.
Youl'll need to add these as members to InboundRpcMessage and update rpcDecode accordingly.
As such, this code does not compile.
- Parth Chandra
On Jan. 6, 2015, 6:30 p.m., Norris Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26371/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 6:30 p.m.)
>
>
> Review request for drill and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Occasionally the client will receive handshake messages from the server. Requests should
be reponded to and responses should be ignored. Spurious Query_Handle and Query_Result messages
(where coordination id and query id = 0, respectively) should also be ignored.
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClientImpl.cpp 23dc407
>
> Diff: https://reviews.apache.org/r/26371/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Norris Lee
>
>
|