drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 31567: 2060 - part 1 - refactor interpreted expression evaluation
Date Sun, 01 Mar 2015 16:16:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31567/#review74701
-----------------------------------------------------------

Ship it!


Refactoring and related changes look ok to me.


exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java
<https://reviews.apache.org/r/31567/#comment121369>

    Is this meant for expressions such as '2.0 + cast(3+4 as double)' ?  It's probably not
very common pattern but you could extract the cast input and minor type and invoke the type-specific
visitor.


- Aman Sinha


On Feb. 28, 2015, 12:15 a.m., Jason Altekruse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31567/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2015, 12:15 a.m.)
> 
> 
> Review request for drill, Aman Sinha, Jacques Nadeau, Jinfeng Ni, and Mehant Baid.
> 
> 
> Bugs: DRILL-2060
>     https://issues.apache.org/jira/browse/DRILL-2060
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> The interpreter was previously not used in normal execution, it was added with unit tests
but never hooked up to an execution component. When trying to use it in the new constant folding
issues I ran into build issues that are described in detail on the 2060 JIRA.
> 
> I have created this to isolate the changes from the others in 2060 for review, but they
are intended to be committed together.
> 
> 
> Diffs
> -----
> 
>   exec/interpreter/pom.xml 20539a8 
>   exec/interpreter/src/test/java/org/apache/drill/exec/expr/ExpressionInterpreterTest.java
a94ef94 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/DrillFuncHolderExpr.java bc631b8

>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillBooleanOPHolder.java
743598a 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalAddFuncHolder.java
3871cd7 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalCastFuncHolder.java
db49173 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalDivScaleFuncHolder.java
683a04f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalMaxScaleFuncHolder.java
aa8e2b5 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalModScaleFuncHolder.java
b5e754e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalSetScaleFuncHolder.java
47b8507 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalSumScaleFuncHolder.java
cb8bfed 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalZeroScaleFuncHolder.java
674fc87 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillSimpleFuncHolder.java
ec284a7 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java 0127e6e

>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/DrillFuncInterpreter.java
3a83542 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/DrillSimpleFuncInterpreter.java
e3696f0 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterBuilder.java
3dac818 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java
0fe36cb 
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterGenerator.java
6cede33 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueHolderHelper.java 2f5bf6a

>   exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java
PRE-CREATION 
>   exec/java-exec/src/test/resources/functions/interp/test_input.csv PRE-CREATION 
>   exec/pom.xml e27e50b 
> 
> Diff: https://reviews.apache.org/r/31567/diff/
> 
> 
> Testing
> -------
> 
> Ran the previous interpreter test, with this and part 2 I am still finishing up some
last debugging on a few type-specific test cases.
> 
> 
> Thanks,
> 
> Jason Altekruse
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message