-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31647/#review74870
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/ColumnList.java
<https://reviews.apache.org/r/31647/#comment121692>
I think it would be helpful to name these as SKIPALL and SCANALL to be more explicit;
SKIP seems to imply we are skipping a few columns only.
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/ColumnList.java
<https://reviews.apache.org/r/31647/#comment121690>
Should the equals method also compare Mode ?
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java
<https://reviews.apache.org/r/31647/#comment121691>
Is this equivalent to instantiating a ColumnList with Mode = SCAN ? Would it be better
to do that?
- Aman Sinha
On March 3, 2015, 12:29 a.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31647/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:29 a.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-2358
> https://issues.apache.org/jira/browse/DRILL-2358
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-2358: Ensure DrillScanRel differentiates skip-all, scan-all & scan-some in
a backward compatible fashion
>
> this is an intermediary change whose functionality will be plugged in by individual storage
plugins. Thus, this patch should not affect the overall stability.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/ColumnList.java
PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java
45e10585f9c5bc303551d342c2602f12026dda17
> exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractRecordReader.java
554b3e77c53039edeeadd7223ab0cec8f0e2c199
>
> Diff: https://reviews.apache.org/r/31647/diff/
>
>
> Testing
> -------
>
> unit tests.
>
>
> Thanks,
>
> Hanifi Gunes
>
>
|