> On March 3, 2015, 4:03 a.m., Venki Korukanti wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java,
line 103
> > <https://reviews.apache.org/r/31651/diff/1/?file=882472#file882472line103>
> >
> > Is it possible to store the reference to FileSplit and create the info string
only when an error occurs (inside the catch block)?
>
> Sudheesh Katkam wrote:
> Two options, which option is better?
> (1) split.getLocations() throws IOException. I thought it would be awkward to have
another try..catch in the catch block.
> (2) Locations are "list of nodes by name where the data for the split would be local".
Do we use data locality?
Oops.. forgot to add. In option (2), if locations need not be logged, then I can do what you
suggested.
- Sudheesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31651/#review74883
-----------------------------------------------------------
On March 3, 2015, 12:53 a.m., Sudheesh Katkam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31651/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:53 a.m.)
>
>
> Review request for drill and Venki Korukanti.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Adding file split information to logs
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java e413921
> exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java
7c1f888
>
> Diff: https://reviews.apache.org/r/31651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sudheesh Katkam
>
>
|