drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuliya Feldman" <yufeldma...@gmail.com>
Subject Re: Review Request 30965: Follow up on DRILL-133 (LocalExchange) to save CPU cycles on hash generation when using in HashToLocalExchange
Date Tue, 03 Mar 2015 08:59:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30965/
-----------------------------------------------------------

(Updated March 3, 2015, 12:59 a.m.)


Review request for drill, Jacques Nadeau, Jinfeng Ni, Steven Phillips, and Venki Korukanti.


Changes
-------

Addressing review comments for UnitTests


Bugs: DRILL-2209
    https://issues.apache.org/jira/browse/DRILL-2209


Repository: drill-git


Description
-------

Insert Project operator to add new column "EXPRHASH" with hash expression for fields that
are used for HashToRandomExchange
Remove Project operator after HashRandomExchange (or Demux) since it will create problems
to fields ordering in HashJoin.

Tight this to MuxExchange - so if MuxExchange is enabled, Project is inserted.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToRandomExchangePrel.java
372c75d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PrelUtil.java 1adc54f

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/30965/diff/


Testing
-------

Need to add Unit Tests. tested live, run Functional and TPCH tests


Thanks,

Yuliya Feldman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message