drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Re: Review Request 34838: DRILL-3155: Part 1
Date Tue, 02 Jun 2015 20:14:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34838/
-----------------------------------------------------------

(Updated June 2, 2015, 8:14 p.m.)


Review request for drill and Hanifi Gunes.


Changes
-------

Addressed review comments.


Repository: drill-git


Description
-------

This patch is a simple refactoring. Moved the classes related to complex vectors in the appropriate
package.


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
00a78fd 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java
b8d040c 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java
323bf43 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java e602fd7 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java
2b929a4 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
0cbd480 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java eddefd0

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d62

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/ContainerVectorLike.java 95e3365

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedFixedWidthVectorLike.java
450c673 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java 8e097e4 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedValueVector.java 95a7252

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVectorLike.java
ac8589e 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/ContainerVectorLike.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
a5553b2 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
a97847b 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedValueVector.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/34838/diff/


Testing
-------


Thanks,

Mehant Baid


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message